You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As surfaced in #2720 (comment), the CI does not currently check for changes in the number of ACVM opcodes generated by a set of benchmark Noir programs.
This leads to the situation where certain PRs could have bumped the number of ACVM opcodes (hence degrade compilation and proving speeds) of certain Noir keywords / language features, where core contributors:
Would not have noticed until the community reports it
Would have to go through a painful debugging process to identify the PR that caused the bump
Happy Case
A set of benchmarking programs should be aligned upon, where the CI should then:
Automatically benchmark the number of ACIR opcodes generated by the programs on each PR
Highlight programs that came with considerable bumps (e.g. ≥+10%) in number of ACIR opcodes
Aztec's implementation of benchmarking doesn't work us as it's a very different usecase. I have a side-project to benchmark Noir programs which we could use with a couple of days of prioritisation.
Problem
As surfaced in #2720 (comment), the CI does not currently check for changes in the number of ACVM opcodes generated by a set of benchmark Noir programs.
This leads to the situation where certain PRs could have bumped the number of ACVM opcodes (hence degrade compilation and proving speeds) of certain Noir keywords / language features, where core contributors:
Happy Case
A set of benchmarking programs should be aligned upon, where the CI should then:
Alternatives Considered
No response
Additional Context
A significant portion of the work could be borrowed from Aztec's implementation: AztecProtocol/aztec-packages#2733
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: