Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache warnings reported by ssa #3300

Closed
guipublic opened this issue Oct 26, 2023 · 0 comments · Fixed by #3313
Closed

Cache warnings reported by ssa #3300

guipublic opened this issue Oct 26, 2023 · 0 comments · Fixed by #3313
Labels
enhancement New feature or request

Comments

@guipublic
Copy link
Contributor

guipublic commented Oct 26, 2023 •
edited
Loading

Problem

When ssa report some warnings, they are not cached so they will be discarded if the same code is compiled again.

Happy Case

We should add the warnings to the DebugInfo so that they can be used when we fetch the result from the cache.
The warnings should also be cached for contracts

Alternatives Considered

No response

Additional Context

See discussion in PR #3205

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@guipublic guipublic added the enhancement New feature or request label Oct 26, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 26, 2023
This was referenced Oct 26, 2023
Merged
Merged
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(3300): cache warnings into debug artefacts noir-lang/noir
1 participant
@guipublic