Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc comments to check_overflow and check_signed_overflow #3381

Closed
kevaundray opened this issue Oct 31, 2023 · 1 comment · Fixed by #3438
Closed

Add doc comments to check_overflow and check_signed_overflow #3381

kevaundray opened this issue Oct 31, 2023 · 1 comment · Fixed by #3438
Assignees
@guipublic
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

These were introduced in this PR #2713 . We should add doc comments to these functions

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added enhancement New feature or request P-LOW labels Oct 31, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 31, 2023
@Savio-Sou Savio-Sou added this to the 0.19 milestone Oct 31, 2023
@Savio-Sou Savio-Sou mentioned this issue Nov 1, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Nov 2, 2023
@jfecher
Copy link
Contributor

jfecher commented Nov 2, 2023

Reopening - #3393 documents overflow in Noir, it does not document the check_overflow or check_signed_overflow functions within the compiler

@jfecher jfecher reopened this Nov 2, 2023
@Savio-Sou Savio-Sou removed this from the 0.19 milestone Nov 2, 2023
@guipublic guipublic mentioned this issue Nov 6, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guipublic guipublic

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add comments to overflow_checks noir-lang/noir
4 participants
@jfecher @kevaundray @guipublic @Savio-Sou