Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile and optimize the compiler #3820

Closed
pczarn opened this issue Dec 15, 2023 · 5 comments
Closed

Profile and optimize the compiler #3820

pczarn opened this issue Dec 15, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@pczarn
Copy link
Contributor

pczarn commented Dec 15, 2023 •
edited
Loading

Problem

Noirc is slow when compiling rsa and other programs.

Happy Case

  1. Profile
  2. Optimize
  3. ???
  4. profit

Alternatives Considered

No alternatives - just profile before optimizing

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

Ideas are welcome
@pczarn pczarn added the enhancement New feature or request label Dec 15, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 15, 2023
@pczarn
Copy link
Contributor Author

pczarn commented Dec 15, 2023

Initial profiling - just debug and not entire compiler run - shows that likely there is plenty of time spent in Instruction::simplify

2023-12-15-153633_628x1058_scrot

@pczarn
Copy link
Contributor Author

pczarn commented Dec 15, 2023

I am using valgrind accompanied by the tools callgrind and kcachegrind and unfortunately a debug build of nargo-cli

@TomAFrench
Copy link
Member

We hugely improved compilation times for noir-rsa in #3815, I'd recommend installing the latest nightly (should be out in 10mins or so)

@pczarn
Copy link
Contributor Author

pczarn commented Dec 15, 2023

Okay. Is anyone else still working on improving compilation times?

@TomAFrench
Copy link
Member

Yep, we're going to keep an eye on compilation times and we're going to need better profiling, etc. going forwards to help with this.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pczarn @TomAFrench