Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type check method calls for ACIR mutable references passed to Brillig #4288

Open
vezenovm opened this issue Feb 7, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@vezenovm
Copy link
Contributor

vezenovm commented Feb 7, 2024

Problem

From this issue #4245 we know that attempting to pass a mutable reference from ACIR to Brillig results in an unclear panic. This should be disallowed and we should expose a clean error.

This PR adds it for normal call expressions #4281.

As noted in this comment we should also have this check occur on method calls.

Happy Case

We should avoid a panic and the same error added in PR #4281 should occur for method calls.

Alternatives Considered

N/A

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@vezenovm vezenovm added the enhancement New feature or request label Feb 7, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 7, 2024
@vezenovm vezenovm changed the title Type check ACIR mutable reference passed to Brillig Type check method calls for ACIR mutable references passed to Brillig Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant