You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From this issue #4245 we know that attempting to pass a mutable reference from ACIR to Brillig results in an unclear panic. This should be disallowed and we should expose a clean error.
This PR adds it for normal call expressions #4281.
As noted in this comment we should also have this check occur on method calls.
Happy Case
We should avoid a panic and the same error added in PR #4281 should occur for method calls.
Alternatives Considered
N/A
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered:
vezenovm
changed the title
Type check ACIR mutable reference passed to Brillig
Type check method calls for ACIR mutable references passed to Brillig
Feb 7, 2024
Problem
From this issue #4245 we know that attempting to pass a mutable reference from ACIR to Brillig results in an unclear panic. This should be disallowed and we should expose a clean error.
This PR adds it for normal call expressions #4281.
As noted in this comment we should also have this check occur on method calls.
Happy Case
We should avoid a panic and the same error added in PR #4281 should occur for method calls.
Alternatives Considered
N/A
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: