Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FieldElement.num_bits() to return 1 for a zero field element. #4759

Closed
TomAFrench opened this issue Feb 22, 2023 · 0 comments · Fixed by #6600
Closed

Update FieldElement.num_bits() to return 1 for a zero field element. #4759

TomAFrench opened this issue Feb 22, 2023 · 0 comments · Fixed by #6600

Comments

@TomAFrench
Copy link
Member

FieldElement.num_bits() currently returns 0 for a zero field element:
https://github.com/noir-lang/acvm/blob/39b8a41293e567971f700f61103852cb987a8d16/acir_field/src/generic_ark.rs#L204-L211

See attached comment: #893 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Noir
Status: ✅ Done
Milestone
No milestone
1 participant
@TomAFrench