Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use dep::{foo, bar} is formatted into use {foo, bar} which is invalid #5299

Closed
TomAFrench opened this issue Jun 20, 2024 · 3 comments
Closed

use dep::{foo, bar} is formatted into use {foo, bar} which is invalid #5299

TomAFrench opened this issue Jun 20, 2024 · 3 comments
Labels
bug Something isn't working formatter

Comments

@TomAFrench
Copy link
Member

TomAFrench commented Jun 20, 2024 •
edited
Loading

See commit AztecProtocol/aztec-packages@d2b4529 which was required workaround for this issue
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 20, 2024
@TomAFrench TomAFrench added the bug Something isn't working label Jun 20, 2024
@TomAFrench TomAFrench mentioned this issue Jun 21, 2024
Closed
@asterite asterite mentioned this issue Jul 5, 2024
Closed
5 tasks
@asterite
Copy link
Collaborator

asterite commented Jul 5, 2024

I think this was introduced in #4946, see https://github.com/noir-lang/noir/pull/4946/files#r1666774807

@TomAFrench
Copy link
Member Author

Solved by new formatter right? @asterite

@asterite
Copy link
Collaborator

It seems so! :-)

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working formatter
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: incorrect parsing of dep::{foo, bar} noir-lang/noir
2 participants
@asterite @TomAFrench