Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify versions of lsp-types used #5522

Closed
TomAFrench opened this issue Jul 16, 2024 · 1 comment
Closed

Unify versions of lsp-types used #5522

TomAFrench opened this issue Jul 16, 2024 · 1 comment

Comments

@TomAFrench
Copy link
Member

As of #5510, we need to use two separate versions of lsp-types due to restrictions on the versions that codespan-reporting supports.

We either need to wait on codespan-reporting to push out a new version which expands this support (doubtful as it's not looking to be maintained brendanzab/codespan#345), fork codespan-reporting or switch to another solution.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 16, 2024
@TomAFrench
Copy link
Member Author

Resolved by https://github.com/noir-lang/noir/pull/5534/files

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomAFrench