Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue : Rework the way arrays are done in SSA #582

Closed
kevaundray opened this issue Dec 13, 2022 · 1 comment · Fixed by #1728
Closed

Tracking Issue : Rework the way arrays are done in SSA #582

kevaundray opened this issue Dec 13, 2022 · 1 comment · Fixed by #1728
Labels
compiler enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

Guillaume noted that we can remove the optimisation that does not copy arrays from functions called.

Solution

Consider re-doing the way arrays are implemented

Alternatives considered

(Describe any alternative solutions you have considered.)

Additional context

(If applicable.)

@kevaundray kevaundray added enhancement New feature or request compiler labels Dec 13, 2022
@jfecher
Copy link
Contributor

jfecher commented Dec 13, 2022

Guillaume noted that we can remove the optimisation that does not copy arrays from functions called.

Reworking arrays should be more pervasive than this. It should be more of an internal refactoring to track arrays through NodeIds like other values instead of through ObjectTypes. Tracking through ObjectTypes does not make much sense as these are converted from the frontend's Type which does not track specific arrays either so this information is not present initially and must be filled in with placeholders until it is fixed later.
When doing this refactoring we should also keep in mind that we want to add additional functionality for arrays/vectors/slices (#374) in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants