Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug SSA pass to normalize all ValueIds #5866

Closed
jfecher opened this issue Aug 29, 2024 · 1 comment
Closed

Add debug SSA pass to normalize all ValueIds #5866

jfecher opened this issue Aug 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Aug 29, 2024

Problem

Debugging large programs in SSA can often be difficult. A small change can lead to large changes in ValueIds which carry over after each pass.

Happy Case

We should add a debug option to re-insert each ValueId starting from v0, v1, etc. This way it will be much easier to diff two different SSA files to see where they start to differ.

The constant folding pass will already re-insert each instruction, although we'd need to force the value ids to be reset.

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the enhancement New feature or request label Aug 29, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 29, 2024
@jfecher
Copy link
Contributor Author

jfecher commented Sep 5, 2024

Implemented in #5909

@jfecher jfecher closed this as completed Sep 5, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant