Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keccak proptest is flakey #5884

Closed
github-actions bot opened this issue Sep 2, 2024 · 2 comments
Closed

keccak proptest is flakey #5884

github-actions bot opened this issue Sep 2, 2024 · 2 comments
Assignees

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

The ACVM crates are currently unpublishable, making a release will NOT push our crates to crates.io.

This is likely due to a crate we depend on bumping its MSRV above our own. Our lockfile is not taken into account when publishing to crates.io (as people downloading our crate don't use it) so we need to be able to use the most up to date versions of our dependencies (including transient dependencies) specified.

Check the MSRV check workflow for details.

This issue was raised by the workflow Test (MSRV check)

@TomAFrench
Copy link
Member

cc @michaeljklein

@TomAFrench TomAFrench changed the title ACVM crates are not publishable keccak proptest is flakey Sep 5, 2024
@michaeljklein
Copy link
Contributor

I believe this is now fixed by #5864

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants