Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Directive::ToLeRadix #6302

Closed
TomAFrench opened this issue Oct 19, 2024 · 2 comments
Closed

Remove Directive::ToLeRadix #6302

TomAFrench opened this issue Oct 19, 2024 · 2 comments
Assignees
Milestone

Comments

@TomAFrench
Copy link
Member

We currently have a single variant of the directive opcode which we use for bit/byte decompositions.

If we perform the decomposition in a brillig function then we can remove this superfluous opcode (and solver) from the ACVM and just have it in the brillig VM.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 19, 2024
@TomAFrench
Copy link
Member Author

This would be implemented by writing a new brillig directive similar to those in https://github.com/noir-lang/noir/blob/master/compiler/noirc_evaluator/src/brillig/brillig_gen/brillig_directive.rs. We could then have the acir-gen code emit a call to this rather than a directive opcode.

Actual removal of the directive opcode would need to be done later in aztec-packages.

@TomAFrench
Copy link
Member Author

Closed by AztecProtocol/aztec-packages#9970

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants