Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression after "Skip array_set pass for Brillig functions" #6565

Closed
sirasistant opened this issue Nov 20, 2024 · 1 comment · Fixed by #6568
Closed

Performance regression after "Skip array_set pass for Brillig functions" #6565

sirasistant opened this issue Nov 20, 2024 · 1 comment · Fixed by #6568
Labels
bug Something isn't working

Comments

@sirasistant
Copy link
Contributor

Aim

Expected Behavior

Bug

After this PR #6513 in conjunction with this one #6552 some functions of aztec contracts have blown up in opcodes executed. Particularly, Uniswap::swap_public is consuming 3 times more gas than before.

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@sirasistant sirasistant added the bug Something isn't working label Nov 20, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 20, 2024
@sirasistant
Copy link
Contributor Author

Added an execution_success test case with one of the functions that blew up in executed opcodes.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant