Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether slice_push_back and similar methods mutate arrays directly #6712

Closed
jfecher opened this issue Dec 5, 2024 · 1 comment

Comments

@jfecher
Copy link
Contributor

jfecher commented Dec 5, 2024

Link to the original PR: #6685 (comment)

Need to investigate for make_array deduplication whether we also shouldn't deduplicate make_array instructions which create slices which are later used in slice_push_back and similar methods. If these methods mutate the slice directly, and a later slice is deduplicated to be the original, then the later slice may have the incorrect mutated value instead of the original.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 5, 2024
@jfecher
Copy link
Contributor Author

jfecher commented Dec 5, 2024

Each slice method (currently at least) copies the slice and returns a new one, so the check in the original PR should be fine.

@jfecher jfecher closed this as completed Dec 5, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant