Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the number of tests being run in parallel for nargo test #6724

Closed
TomAFrench opened this issue Dec 6, 2024 · 3 comments · Fixed by #6728
Closed

Restrict the number of tests being run in parallel for nargo test #6724

TomAFrench opened this issue Dec 6, 2024 · 3 comments · Fixed by #6728
Assignees

Comments

@TomAFrench
Copy link
Member

We're currently unable to run the tests for https://github.com/noir-lang/noir-bignum due to nargo test attempting to run all of the tests in parallel, resulting in it just running out of memory and the process being killed.

As a short term fix, we should restrict the number of threads which nargo test will use so that we can run these tests in github CI. We can set the RAYON_NUM_THREADS environment variable internally to set the max number of threads.

@asterite
Copy link
Collaborator

asterite commented Dec 6, 2024

Regarding this, it seems Rust runs tests in parallel for each package, but each package tests (as groups) run sequentially. Do we want to do the same? Right now that's not the case... though I feel that the current way is probably fine.

@TomAFrench
Copy link
Member Author

Yeah, I think that running packages serially makes sense.

@TomAFrench
Copy link
Member Author

TomAFrench commented Dec 6, 2024

This ensures all the tests for a single package will be printed together which is what we want tbh.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants