Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nargo): Leverage rustls instead of openssl for downloads #691

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Jan 24, 2023

Related issue(s)

Description

(Currently a draft to discuss) This updates the aztec_backend package to point at my commit in noir-lang/acvm-backend-barretenberg#46 - which replaces the openssl dependency with rustls. This is a dependency that doesn't require openssl to exist on a system, and helps with cross-compilation. I found out that they don't have complete support (e.g. RISC-V is unsupported) but they seem to support all the platforms we really care about.

This allows us to remove a hack that we have in the build-nargo workflows to cross-compile the linux binaries.

Summary of changes

Updates aztec_backend, which still needs to be reviewed and merged upstream.

Dependency additions / changes

aztec_backend

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

@phated phated changed the title Leverage rustls instead of openssl for downloads feat(nargo): Leverage rustls instead of openssl for downloads Feb 3, 2023
@phated phated force-pushed the phated/rustls branch 2 times, most recently from 62d6fed to ed31068 Compare February 6, 2023 16:48
@phated phated marked this pull request as ready for review February 6, 2023 17:06
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of removing the requirement for users to have openssl. It is a common error that is encountered when trying to build noir from source that it is missing. It is not as important now that binaries are being emphasized but I still think it is good to have building from source be as easy as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants