Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hardcode the maximum global memory space #7107

Closed
vezenovm opened this issue Jan 17, 2025 · 0 comments · Fixed by #7151
Closed

Do not hardcode the maximum global memory space #7107

vezenovm opened this issue Jan 17, 2025 · 0 comments · Fixed by #7151
Assignees
Labels
brillig Unconstrained functions / brillig IR enhancement New feature or request

Comments

@vezenovm
Copy link
Contributor

Problem

In #7021 for simplicity we hardcoded a MAX_GLOBAL_SPACE. This is used by both the GlobalSpace memory allocator and for determining the calldata start offset when copying calldata for the entry point. As we know globals at compile time we should be able to set the max memory allocated based upon the globals the user has specified.

Happy Case

There will be no hardcoded MAX_GLOBAL_SPACE and the memory allocated will be determined by the globals specified by the user.

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

Blocker

Blocker Context

This will block programs with a large amount of globals.

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@vezenovm vezenovm added brillig Unconstrained functions / brillig IR enhancement New feature or request labels Jan 17, 2025
@vezenovm vezenovm self-assigned this Jan 17, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 17, 2025
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brillig Unconstrained functions / brillig IR enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant