Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some form of versioning to CompiledProgram #711

Closed
TomAFrench opened this issue Jan 30, 2023 · 2 comments
Closed

Add some form of versioning to CompiledProgram #711

TomAFrench opened this issue Jan 30, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

Problem

Imagine we compile a circuit and save it to file and leave it for a year. This circuit has been compiled with the expectation that it will have access to certain blackbox functions, input witnesses will be laid out in a certain fashion, etc.

We then come back a year later and want to prove against this circuit. We then would have to perform trial and error to find the correct backend to prove against.

Solution

We should include some identifier to flag that the circuit expects a particular backend to avoid the potential for mystery failures/unexpected behaviour when trying to prove/verify against a different backend.

Alternatives considered

Alternatively we can leave this as is.

Additional context

@TomAFrench TomAFrench added the enhancement New feature or request label Jan 30, 2023
@kevaundray
Copy link
Contributor

The output of Noir should be backend agnostic* -- at the moment, we apply optimisations inside of the evaluator specific to a backend which make this not entirely true, though there is an issue open for that here

We do need to add versioning infromation to the compiled program as the unoptimised IR can change over time, we could, as you noted, additionally add information to the optimised ACIR given a canonical format for naming backends

@TomAFrench TomAFrench changed the title Include some record of which backend a CompiledProgram was compiled against Add some form of versioning to CompiledProgram Feb 16, 2023
@kevaundray
Copy link
Contributor

@TomAFrench whats the status of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants