Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa): synchronisation for functions #764

Merged
merged 7 commits into from
Feb 9, 2023
Merged

fix(ssa): synchronisation for functions #764

merged 7 commits into from
Feb 9, 2023

Conversation

guipublic
Copy link
Contributor

Description

Summary of changes

This PR fixes the synchronisation of ELSE/THEN branches. As a result, we now need to properly optimise result instructions coming from the branches.

Test additions / changes

Test case added in 9_conditional

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

@guipublic
fix synchronisation for functions
0163782 
ensure result instructions are optimised after synchronisation
jfecher
jfecher reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Lets leave some comments in the code explaining why we're calling the same functions twice in a row and then this PR should be ready

@kevaundray
Copy link
Contributor

Been trying to merge this, but PRs keep getting merged infront of it -- This will be fixed once we enable Merge Queues!

@kevaundray kevaundray merged commit 615357a into master Feb 9, 2023
@kevaundray kevaundray deleted the gd/function_sync branch February 9, 2023 06:02
@github-actions github-actions bot mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray left review comments

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guipublic @kevaundray @jfecher