Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect cloning of InternalVar in acir_gen #770

Closed
kevaundray opened this issue Feb 8, 2023 · 0 comments · Fixed by #984
Closed

Remove incorrect cloning of InternalVar in acir_gen #770

kevaundray opened this issue Feb 8, 2023 · 0 comments · Fixed by #984
Assignees
Labels
enhancement New feature or request refactor ssa

Comments

@kevaundray
Copy link
Contributor

Problem

In acir_gen, each time we fetch an InternalVar using a NodeId and generate a cached_witness that cached_witness is not saved back into the internal_var_cache, so fetching the same InternalVar again using the same NodeId will not show the cached_witness.

Solution

  • One solution is to update the InternalVarCache whenever we generate a witness for an expression in an InternalVar

Alternatives considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor ssa
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants