Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Build binaries when a release is made #773

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Feb 8, 2023

Related issue(s)

Description

This adds jobs to the release workflow that trigger creation of binaries for that tag (using the build-nargo repository) that will be uploaded to the release tag.

These only trigger if release-please has created a tag, so nothing extra is added for normal merging workflows.

Summary of changes

Added a step for each target platform.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't know we supported windows binaries even with wasm

@phated
Copy link
Contributor Author

phated commented Feb 8, 2023

I didn't know we supported windows binaries even with wasm

Yep! And they are even lightly tested by the workflow before being uploaded 🎉

@phated phated merged commit a0c0c2c into master Feb 8, 2023
@phated phated deleted the phated/release-binaries branch February 8, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants