Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove witness option from nargo compile #877

Closed
TomAFrench opened this issue Feb 20, 2023 · 0 comments · Fixed by #878
Closed

Remove witness option from nargo compile #877

TomAFrench opened this issue Feb 20, 2023 · 0 comments · Fixed by #878
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

TomAFrench commented Feb 20, 2023

Problem

This flag seems quite out of place in my mind, due to how it's "skipping ahead" in the pipeline from code to generating a proof.

The analogy is that nargo execute is to nargo compile what cargo run is to cargo build and you would never pass runtime args to cargo build.

Solution

We can remove this flag and just use the nargo execute [witness_name] argument if we want to write a witness to file. This maintains the general flow of each command can only call into the previous steps to generate its inputs.

(There is an issue with my argument here with the nargo prove --verify flag also "skipping ahead" but I'd argue that this is acceptable as it's just a validity check rather than producing new outputs.)

Alternatives considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant