Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: prevent inconsistent language usage in Driver #881

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves #880

Description

Summary of changes

I've removed np_language from the interface of Driver and it now just uses the locally stored language when compiling.

We could make this a non-breaking change by maintaining the same interface while adding an assert_eq(np_language, &self.langauge) to each method which uses it. My feeling however is that we're going to be the only consumer of this API currently so we can make this breaking change safely.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@kevaundray kevaundray added this pull request to the merge queue Feb 20, 2023
Merged via the queue into master with commit 48cda7a Feb 20, 2023
@kevaundray kevaundray deleted the driver-language branch February 20, 2023 18:39
This was referenced Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that Driver always runs against a consistent language
2 participants