fix!: prevent inconsistent language usage in Driver
#881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #880
Description
Summary of changes
I've removed
np_language
from the interface ofDriver
and it now just uses the locally stored language when compiling.We could make this a non-breaking change by maintaining the same interface while adding an
assert_eq(np_language, &self.langauge)
to each method which uses it. My feeling however is that we're going to be the only consumer of this API currently so we can make this breaking change safely.Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Additional context