Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abi): ensure that return value is loaded from toml #883

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves #860 (review)

Description

Summary of changes

When loading inputs from toml we need their AbiType to be included in the map abi_map. Due to #865, this doesn't get inserted automatically so we panic when loading return values.

We now insert the return type into the map so we can load toml files correctly again.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good to me. I just ran into it when trying to run nargo prove and nargo verify separately rather than nargo prove --verify. The separate prove and verify commands are now working for me

@TomAFrench TomAFrench added this pull request to the merge queue Feb 21, 2023
@TomAFrench
Copy link
Member Author

Yeah, I tend to use nargo prove --verify quite a bit so this slipped through when testing locally. We should potentially re-add some integration tests which write to file as we used to in order to catch stuff like this.

Merged via the queue into master with commit adba24c Feb 21, 2023
@TomAFrench TomAFrench deleted the toml-fix branch February 21, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants