Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow parsing strings from toml into booleans #894

Merged
merged 2 commits into from
Feb 23, 2023
Merged

fix: allow parsing strings from toml into booleans #894

merged 2 commits into from
Feb 23, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves #890

Description

Summary of changes

AbiType::Boolean has been added to the necessary match arm to allow parsing.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench requested a review from jfecher February 21, 2023 20:23
jfecher
jfecher previously approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Perhaps we should remove the match all here to prevent errors like this in the future

@TomAFrench TomAFrench added this pull request to the merge queue Feb 22, 2023
@TomAFrench TomAFrench removed this pull request from the merge queue due to a manual request Feb 22, 2023
@TomAFrench TomAFrench requested a review from jfecher February 22, 2023 12:52
@TomAFrench
Copy link
Member Author

I've removed the catch-all arm as suggested.

@TomAFrench
Copy link
Member Author

@jfecher could you reapprove this please? I'd like to start this going in the merge queue.

@TomAFrench TomAFrench enabled auto-merge February 23, 2023 12:55
@TomAFrench TomAFrench added this pull request to the merge queue Feb 23, 2023
Merged via the queue into master with commit f729a00 Feb 23, 2023
@TomAFrench TomAFrench deleted the string-bool-parsing branch February 23, 2023 14:34
@kevaundray kevaundray mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-generated Verifier.toml produces unreadable toml for bool parameters
2 participants
@TomAFrench @jfecher