Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: replace dummy ABIs with FunctionSignature type alias #930

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Description

Summary of changes

Following #851, we're now exposing methods to compute an "ABI" which doesn't contain half the fields of an actual ABI (namely, the witness maps). We then need some reduced ABI-ish format which just tells us what the arguments/return values are and should look like.

This PR introduces this as a FunctionSignature type alias which just describes the arguments and return values of a function.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

crates/nargo/src/cli/check_cmd.rs Show resolved Hide resolved
crates/nargo/src/cli/check_cmd.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomAFrench TomAFrench added this pull request to the merge queue Mar 1, 2023
Merged via the queue into master with commit 156125b Mar 1, 2023
@TomAFrench TomAFrench deleted the function-signature branch March 1, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants