Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ssa): add location to ssa instructions #931

Merged
merged 4 commits into from
Mar 7, 2023
Merged

feat(ssa): add location to ssa instructions #931

merged 4 commits into from
Mar 7, 2023

Conversation

guipublic
Copy link
Contributor

Related issue(s)

Extends #231 for out-of-bound index and division-by-zero

Description

Summary of changes

Location is added to ssa instructions that can fail during ssa pass, such as division and array access. It is used to report the error.

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

jfecher
jfecher reviewed Feb 28, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and straightforward. Just one question

crates/noirc_evaluator/src/ssa/node.rs Show resolved Hide resolved
@kevaundray
Copy link
Contributor

Awesome!

@kevaundray kevaundray self-requested a review March 7, 2023 22:05
@kevaundray kevaundray added this pull request to the merge queue Mar 7, 2023
Merged via the queue into master with commit 356858b Mar 7, 2023
@kevaundray kevaundray deleted the gd/debug_info branch March 7, 2023 22:45
@kevaundray kevaundray mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher left review comments

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guipublic @kevaundray @jfecher