Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove uses of std::process::exit #963

Merged
merged 5 commits into from
Mar 8, 2023
Merged

fix: Remove uses of std::process::exit #963

merged 5 commits into from
Mar 8, 2023

Conversation

Ethan-000
Copy link
Contributor

@Ethan-000 Ethan-000 commented Mar 8, 2023 •
edited
Loading

Related issue(s)

Resolves #729

Description

Summary of changes

replacing std::process::exit to either

  1. CliError if its in nargo or

  2. ReportedError if its in driver

  3. add a panic! to wasm crate

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

TomAFrench
TomAFrench reviewed Mar 8, 2023
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary for this PR but I think we should start considering the use of ReportedError. The driver should most likely return return its own specialised errors rather than a generic one like this.

crates/nargo/src/cli/compile_cmd.rs Outdated Show resolved Hide resolved
@TomAFrench TomAFrench added this pull request to the merge queue Mar 8, 2023
Merged via the queue into noir-lang:master with commit 870ea46 Mar 8, 2023
@kevaundray kevaundray mentioned this pull request Mar 8, 2023
Merged
@Ethan-000 Ethan-000 deleted the remove_exit branch March 8, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove uses of std::process::exit
2 participants
@Ethan-000 @TomAFrench