You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We recently had an issue where the function to save an ACIR checksum was using a different extension to the function which was reading this when loading the circuit's keys: #993
This is all easily testable so there's no excuse for not checking that these functions work together as expected (this was part of the original reasoning between factoring these into the fs module in the first place).
Proposed solution
We should add unit tests for each function to check that if a value is written to file then it will be successfully read again by the appropriate function if we pass the correct arguments into it. For an example of this see #994
Alternatives considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
Problem
We recently had an issue where the function to save an ACIR checksum was using a different extension to the function which was reading this when loading the circuit's keys: #993
This is all easily testable so there's no excuse for not checking that these functions work together as expected (this was part of the original reasoning between factoring these into the
fs
module in the first place).Proposed solution
We should add unit tests for each function to check that if a value is written to file then it will be successfully read again by the appropriate function if we pass the correct arguments into it. For an example of this see #994
Alternatives considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: