Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to check that fs loader functions will recover values saved by writers #995

Closed
TomAFrench opened this issue Mar 16, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

Problem

We recently had an issue where the function to save an ACIR checksum was using a different extension to the function which was reading this when loading the circuit's keys: #993

This is all easily testable so there's no excuse for not checking that these functions work together as expected (this was part of the original reasoning between factoring these into the fs module in the first place).

Proposed solution

We should add unit tests for each function to check that if a value is written to file then it will be successfully read again by the appropriate function if we pass the correct arguments into it. For an example of this see #994

Alternatives considered

No response

Additional context

No response

@kevaundray
Copy link
Contributor

@TomAFrench What is the status of this issue?

@TomAFrench
Copy link
Member Author

This is not really an issue now that we have a single artifact for circuits.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants