Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svcwatcher shouldn't try and deal with Endpoints, Pods, Services, and DanmEps which are not in the same namespace as the changed object #191

Closed
Levovar opened this issue Mar 16, 2020 · 0 comments · Fixed by #200
Labels
enhancement New feature or request

Comments

@Levovar
Copy link
Collaborator

Levovar commented Mar 16, 2020

However currently this is unoptimized, and it does.
This is dues to using generic Lister K8s client go API: https://github.com/kubernetes/client-go/blob/kubernetes-1.11.10/listers/core/v1/service.go#L31
rather than the NamespaceLister one: https://github.com/kubernetes/client-go/blob/kubernetes-1.11.10/listers/core/v1/service.go#L33

it does not result in functional error, but can generate misleading error messages, and unnecessary event processing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant