Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix category when unsetting customEmoji #277

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Conversation

nolanlawson
Copy link
Owner

Fixes #276

@nolanlawson nolanlawson changed the title fix: fix category with unsetting customEmoji fix: fix category when unsetting customEmoji Apr 16, 2022
@github-actions
Copy link

github-actions bot commented Apr 16, 2022

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-database-interactions: unsure 🔍 -2% - +5% (-2.35ms - +6.62ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -5% - +8% (-3.57ms - +5.85ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -2% - +9% (-1.24ms - +6.18ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
136.60ms - 143.34ms-unsure 🔍
-2% - +5%
-2.35ms - +6.62ms
tip-of-tree
tip-of-tree
134.88ms - 140.79msunsure 🔍
-5% - +2%
-6.62ms - +2.35ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
68.47ms - 75.47ms-unsure 🔍
-5% - +8%
-3.57ms - +5.85ms
tip-of-tree
tip-of-tree
67.68ms - 73.99msunsure 🔍
-8% - +5%
-5.85ms - +3.57ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
68.86ms - 73.57ms-unsure 🔍
-2% - +9%
-1.24ms - +6.18ms
tip-of-tree
tip-of-tree
65.88ms - 71.62msunsure 🔍
-9% - +2%
-6.18ms - +1.24ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

Size Change: +17 B (0%)

Total Size: 41.8 kB

Filename Size Change
./bundle.js 41.8 kB +17 B (0%)

compressed-size-action

@nolanlawson nolanlawson merged commit 3601f79 into master Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in the demo
1 participant