[PR] Optional finalizers

[kopf-archiver]

A pull request by dlmiddlecote at 2019-06-16 23:08:10+00:00
Original URL: zalando-incubator/kopf#118
Merged by nolar at 2019-07-03 16:24:02+00:00

Issue : #24

Description

Adding finalizers to resources means that resources cannot be deleted if the operator is not running. This PR makes sure that finalizers are added only when strictly necessary, i.e. when there are mandatory deletion handlers. If there are no deletion handlers registered, then no finalizers will be added, same if a deletion handler is marked as optional.

Types of Changes

What types of changes does your code introduce? Keep the ones that apply:

• New feature (non-breaking change which adds functionality)
• Documentation / non-code

Tasks

List of tasks you will do to complete the PR

• Add documentation

Review

List of tasks the reviewer must do to review the PR

• Tests
• Documentation

---

Commented by dlmiddlecote at 2019-06-17 16:46:59+00:00
 

Thank you for your review! I’ll get onto making the changes ASAP.

---

Commented by nolar at 2019-06-26 13:40:47+00:00
 

dlmiddlecote Just for information regarding delay: All is okay with this PR. I will merge it a bit later. There is a little issue in the master branch (merged, but not released yet), which I would like to fix and release as a separate version without any intermediate merges; and also to keep the releases' deltas small.