Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Obey the configured levels when posting from logging #192

Closed
2 tasks
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed
2 tasks

[PR] Obey the configured levels when posting from logging #192

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive bug Something isn't working

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-09-25 21:37:11+00:00
Original URL: zalando-incubator/kopf#192
Merged by nolar at 2019-09-26 10:56:44+00:00

Fix an issue with k8s-events posted for log messages despite the configured levels.

Issue : fixes #188

Description

Configured log levels was ignored in the connector of the logging facilities to the k8s-event posting engine, so all events were posted. The docs were written for the event-posting shortcuts, but this was not taken into account when the log-posting engine was added.

In addition, some extra checks are added to verify that the shortcuts actually obey the configured levels.

Note that the debug level messages are now filtered not by the K8s-posting handler K8sPoster — the minimum level is removed from there— but by its filter() method, based on the Kopf's configs. Which is generally equivalent, as it was previously filtered by level in super().filter(record), which stands in the same line.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

Review

List of tasks the reviewer must do to review the PR

  • Tests
  • Documentation
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Obey the configured levels when posting from logging Aug 19, 2020
@kopf-archiver kopf-archiver bot added the bug Something isn't working label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants