You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Configured log levels was ignored in the connector of the logging facilities to the k8s-event posting engine, so all events were posted. The docs were written for the event-posting shortcuts, but this was not taken into account when the log-posting engine was added.
In addition, some extra checks are added to verify that the shortcuts actually obey the configured levels.
Note that the debug level messages are now filtered not by the K8s-posting handler K8sPoster — the minimum level is removed from there— but by its filter() method, based on the Kopf's configs. Which is generally equivalent, as it was previously filtered by level in super().filter(record), which stands in the same line.
Types of Changes
Bug fix (non-breaking change which fixes an issue)
Review
List of tasks the reviewer must do to review the PR
Tests
Documentation
The text was updated successfully, but these errors were encountered:
Fix an issue with k8s-events posted for log messages despite the configured levels.
Description
Configured log levels was ignored in the connector of the
logging
facilities to the k8s-event posting engine, so all events were posted. The docs were written for the event-posting shortcuts, but this was not taken into account when the log-posting engine was added.In addition, some extra checks are added to verify that the shortcuts actually obey the configured levels.
Note that the debug level messages are now filtered not by the K8s-posting handler
K8sPoster
— the minimum level is removed from there— but by itsfilter()
method, based on the Kopf's configs. Which is generally equivalent, as it was previously filtered by level insuper().filter(record)
, which stands in the same line.Types of Changes
Review
List of tasks the reviewer must do to review the PR
The text was updated successfully, but these errors were encountered: