Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Avoid meaningless logging and patching #236

Closed
1 task
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed
1 task

[PR] Avoid meaningless logging and patching #236

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive enhancement New feature or request

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-11-15 10:44:05+00:00
Original URL: zalando-incubator/kopf#236
Merged by nolar at 2019-11-15 11:42:02+00:00

Less patching, less logging when not needed.

Issue : #1234 (only if appropriate)

Description

Skip logging the empty diffs. They are useless. Especially on the resuming events, when the object is not changed actually. — As they are already skipped for the creation/deletion events, when the diff is a full-body vs. None diff.

Skip patching the body essence if it is the same as the one already stored on the object. This pollutes the logs with difficult-to-read JSON dumps, especially on the resuming events — when these patches and logs contain no useful information.

Skip purging the handler progress if there is no progress stored (e.g. for one-handler cases, when it succeeds immediately). This produced unnecessary API patches, and polluted the logs for no good reason.

These changes will reduce the amount of meaningless logs produced.

Types of Changes

  • Refactor/improvements

Review

List of tasks the reviewer must do to review the PR

  • Tests
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Avoid meaningless logging and patching Aug 19, 2020
@kopf-archiver kopf-archiver bot added the enhancement New feature or request label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

0 participants