[PR] Simplify registries: no prefixes, direct sub-registries access

[kopf-archiver]

A pull request by nolar at 2020-02-20 12:54:51+00:00
Original URL: zalando-incubator/kopf#315
Merged by nolar at 2020-02-20 16:05:16+00:00

What do these changes do?

Refactor the registries massively, to prepare for even more registry and handler types.

Description

Originally, there were sub-registries and one operator registry consisting of sib-registries. And the operator registry was exposing multiple registed_blah_blah_handler(), [has|get|iter]_blah_blah_handlers() methods, so on.

As the number of handler type increases, having these proxying methods becomes a problem: they do nothing, just proxy to the actual sub-registries (simple lists), but bring a lot of method signatures that has to be maintained and tested.

With this PR, we remove all of these proxying methods completely (technically, deprecate them and warn if they are used, but keep them for a while until the next major release).

The sub-registries should now be used directly, and its handlers should be accesses via the similar methods (same-named, but different typing signatures: e.g. [get|iter]_handlers(...)).

Purpose: In the following PRs, even more registry and handler types will be added: e.g. daemons & timers. Not having even more proxying methods seems convenient.

---

Also, registries prefixes are removed. They were used for the sub-handlers only. Now, the prefixes are implemented directly for sub-handler decorators.

Since registries were never created directly by the users (unlike the accessing methods above), we have no need to keep backward compatible changes for deprecated prefixes — we just drop them.

---

The end users should not be affected (in theory).

Issues/PRs

Issues: #19

Related: #298

Type of changes

• Refactoring (non-breaking change which does not alter the behaviour)

Checklist

• The code addresses only the mentioned problem, and this problem only
• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt