Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent removing and re-adding of the slideVisibleClass and slideFullyVisibleClass classes #7505

Conversation

WesselKroos
Copy link
Contributor

(This is similar to previously fixed performance issue #7355, but for another slide class this time.)

Prevents removing and re-adding of the slideVisibleClass and slideFullyVisibleClass classes. This happens for every scroll/move when watchSlidesProgress is enabled, causing an unnecessary performance penalty.

Fixes #7504

…revents unnecessary style recalculations (This performance difference is mostly noticable when moving a slide with a mouse or touchmove because updateSlidesProgress is triggered for every keyboard-/touchevent)
@nolimits4web
Copy link
Owner

t0ggles-create swiper

Copy link

t0ggles bot commented Apr 30, 2024

Task nolimits4web/SWIPER-96 was created

t0ggles task SWIPER-96

@t0ggles t0ggles bot added the t0ggles Linked to the t0ggles task label Apr 30, 2024
@nolimits4web nolimits4web merged commit 2c08227 into nolimits4web:master May 13, 2024
3 checks passed
Copy link

t0ggles bot commented May 13, 2024

Task nolimits4web/SWIPER-96 status changed to Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t0ggles Linked to the t0ggles task
Projects
None yet
2 participants