Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiper.destroy() not working when createElements is enabled #7530

Labels
t0ggles Linked to the t0ggles task

Comments

@samzabala
Copy link

samzabala commented May 13, 2024

Check that this is really a bug

  • I confirm

Reproduction link

https://codesandbox.io/p/sandbox/swiper-stupid-38lq4g?file=%2Findex.html

Bug description

swiper.destroy() not working when createElements is enabled. wrapperEl is created dynamically when set to true, but destroy breaks scripts and returns fatal error when this is the setup

Error:
0:4290 Uncaught TypeError: Cannot read properties of undefined (reading 'removeAttribute')

Demo:
https://codesandbox.io/p/sandbox/swiper-stupid-38lq4g?file=%2Findex.html

Offending line was found ion the destroy method :

wrapperEl.removeAttribute('style');

could be fixed if there is a condition to check if it exists first

if(wrapperEl) wrapperEl.removeAttribute('style');

please help. thank

Expected Behavior

destroy the slider

Actual Behavior

destroys the site

Swiper version

~11.0.5 - 11.1.1 and 11.1.2 checked

Platform/Target and Browser Versions

Chrome/Edie/Webkit Mac OS

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@nolimits4web
Copy link
Owner

t0ggles-create swiper

Copy link

t0ggles bot commented May 13, 2024

Task nolimits4web/SWIPER-133 was created

t0ggles task SWIPER-133

@t0ggles t0ggles bot added the t0ggles Linked to the t0ggles task label May 13, 2024
Copy link

t0ggles bot commented May 30, 2024

Task nolimits4web/SWIPER-133 status changed to Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment