Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual slides + History bug #7327

Closed
5 of 6 tasks
dmaus opened this issue Feb 21, 2024 · 0 comments · Fixed by Mapuppy09/tradetrust-website#8 · 4 remaining pull requests
Closed
5 of 6 tasks

Virtual slides + History bug #7327

dmaus opened this issue Feb 21, 2024 · 0 comments · Fixed by Mapuppy09/tradetrust-website#8 · 4 remaining pull requests
Labels

Comments

@dmaus
Copy link

dmaus commented Feb 21, 2024

Check that this is really a bug

  • I confirm

Reproduction link

https://codesandbox.io/p/devbox/swiper-vue-virtual-slides-history-rwhdwd

Bug description

Not able to change the browser history after two slides.
At slide 3 it adds /4 in the browser URL.
History changes only show in preview mode: https://rwhdwd-5173.csb.app/

Expected Behavior

Changing the history according to that data-history attribute.

Actual Behavior

Using wrong slides for history change beginning at the third slide first, later throwing an error:
Cannot read properties of undefined (reading 'getAttribute')

Swiper version

11.0.6

Platform/Target and Browser Versions

macOS Chrome 121.0.6167.184 (Official Build) (x86_64)

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment