-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3d Cube hides slides on Safari for Mac Ventura #7532
3d Cube hides slides on Safari for Mac Ventura #7532
Comments
Safari 17 on Sonoma can't see any issues |
We already do it in code (if you check) but we check for safari < 16.2 where this issue was present. Not sure how to detect the case for Ventura-only and not sure if it is actually needed |
I'm using Safari 17.4.1 on Ventura 13.6.6 and the issue was still there. As you can see by attached screen recording. I also added two demo files. The one in the 'bug' folder is using the standard CDN at https://cdn.jsdelivr.net/npm/swiper@11/swiper-bundle.min.js. The 2nd in the 'fix' folder: here I downloaded above swiper-bungle.min.js file and changed it. Notice how I added '0.01' to all occurrences of rotateX and rotateY. To make sure that a rotation of exactly 90deg isn't done, but one of 90.01 instead. When I use this demo all sides of the cube are visible. If you replace the CDN file with that in the 'fix' folder us Ventura users should see the cube working again. bug.zip |
@nolimits4web Did you have the time to check out my slightly changed swiper-bundle.min.js file where I had 0.01 added to each rotateX/rotateY occurrence? Would be great if the CDN could be updated likewise and us Ventura users could enjoy a fully visible cube again 🙂 |
Why closing this issue while it is still an issue on Safari 17 / Ventura 13? Instead of using my slightly updated file as the fix? |
Aha I see that you've updated the CDN file yesterday, @nolimits4web. The cube is working on Ventura 13 now. Thanks for fixing it. |
Check that this is really a bug
Reproduction link
https://swiperjs.com/demos/230-effect-cube/core
Bug description
On Safari for Mac the cube doesn't work. Only the front and back side of it are visible and not the left and right side. This is because of the 90 degrees rotation. When an element is rotated exactly 90 degrees Safari on Ventura regards it as invisible and won't show it when it is animated. This is some kind of bug in Safari on Ventura specifically (Safari on other OS's work normally), but can be fixed.
In order for swiper.js to work the CDN swiper-bundle.min.js file should be adjusted so that on every rotateX and rotateY something like an extra '0.01' is added to the 'deg' value. It will still rotate the elements 90 degrees (as the browser will round the 90.01 down to 90), but Safari won't consider objects initially rotated 90.01 as hidden anymore. As long as the deg value isn't exactly 90, otherwise Safari hides it.
Expected Behavior
I should see all sides of the cube
Actual Behavior
Only the front and back slide of the cube are visible
Swiper version
11.1.3
Platform/Target and Browser Versions
Safari 17 on OSX Ventura
Validations
Would you like to open a PR for this bug?
The text was updated successfully, but these errors were encountered: