Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(signers): move SignerConf to ethereum-specific folder in configuration crate #143

Open
luketchang opened this issue May 2, 2022 · 0 comments
Open

refactor(signers): move SignerConf to ethereum-specific folder in configuration crate #143

luketchang opened this issue May 2, 2022 · 0 comments
Labels
good first issue Good for newcomers refactor

Comments

@luketchang
Copy link
Collaborator

luketchang commented May 2, 2022 •
edited
Loading

  • SignerConf is an ethereum-specific type yet it sits in general crates (configuration and nomad-core)
  • Want to move SignerConf into ethereum specific folder in configuration and generalize with VM-based enums
@luketchang luketchang added the good first issue Good for newcomers label May 9, 2022
@luketchang luketchang changed the title refactor(signers): move Signers and SignerConf to ethereum-specific crates refactor(signers): move Signers and SignerConf to ethereum-specific crates May 9, 2022
@luketchang luketchang changed the title refactor(signers): move Signers and SignerConf to ethereum-specific crates refactor(signers): move SignerConf to ethereum-specific folder in configuration crate May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luketchang