Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(configuration): test specifying replicas in env #161

Closed
luketchang opened this issue May 11, 2022 · 1 comment
Closed

test(configuration): test specifying replicas in env #161

luketchang opened this issue May 11, 2022 · 1 comment

Comments

@luketchang
Copy link
Collaborator

#153 added functionality for loading specified replicas rather than all in config. Tested cases manually but need to add automated tests for edge cases.

Cases:

  1. AGENT_REPLICAS_ALL=true, but specify specific replicas (ALL should override)
  2. AGENT_REPLICAS_ALL=false, but don't specify any replicas (should fail to load with error)
  3. AGENT_REPLICAS_ALL not specified, but don't specify any replicas (should fail to load with error)
@luketchang
Copy link
Collaborator Author

Closed by #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luketchang