Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSAssert annotation #5

Open
zsalab opened this issue Oct 31, 2019 · 3 comments
Open

JSAssert annotation #5

zsalab opened this issue Oct 31, 2019 · 3 comments

Comments

@zsalab
Copy link

zsalab commented Oct 31, 2019

I am happy to find this project, I really appreciate the effort you put in it. I would like to propose to detach the JSAssert validation functionality to a separate module because bring the heavy graalvm JS engine which is itself 15M+
I think would be a great idea to separate that functionality to separated jar

@nomemory
Copy link
Owner

@zsalab You are right. I will do that when I will have some available time.

@Tosken1337
Copy link

GraalVM js engine is still in the compile time dependencies. I think this could be removed now?

@nomemory
Copy link
Owner

Yes, it can be removed. I will try to make a new release without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants