fix: upload failure due to non-rgb image #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| # Auto resize to max 512x512 | ||
| image = Image.open(blob) | ||
| image = image.convert("RGB") | ||
| if image.height > 512 or image.width > 512: |
There was a problem hiding this comment.
The resizing logic should maintain the aspect ratio. Consider using image.thumbnail((512, 512), Image.ANTIALIAS) to resize while maintaining the aspect ratio.
apage43
approved these changes
Aug 26, 2024
bmschmidt
reviewed
Aug 27, 2024
bmschmidt
approved these changes
Aug 27, 2024
nomic/dataset.py
Outdated
| @@ -1420,6 +1421,7 @@ def _add_blobs( | |||
| elif isinstance(blob, bytes): | |||
| images.append((uuid, blob)) | |||
| elif isinstance(blob, Image.Image): | |||
| image = image.convert("RGB") | |||
There was a problem hiding this comment.
The conversion of images to RGB format is repeated in the _add_blobs function. Consider refactoring to avoid this repetition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes image upload failures by converting non-RGB images to RGB format in
nomic/dataset.py.Key points:
nomic/dataset.py._add_blobsfunction.Generated with ❤️ by ellipsis.dev