Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NANO & stablecoins? #15

Open
geosme opened this issue Dec 27, 2019 · 3 comments · May be fixed by #34
Open

Support for NANO & stablecoins? #15

geosme opened this issue Dec 27, 2019 · 3 comments · May be fixed by #34

Comments

@geosme
Copy link

geosme commented Dec 27, 2019

Possible to consider adding support for some stablecoins and NANO?

Appreciated.

Great work team

@nomiddleman
Copy link
Owner

Nano has been looked at and we could do it without Autopay.

@pierstitus
Copy link

I'm using this plugin, great work!

I'd love to see Nano support. For adding basic support without autopay is it enough to add a line to src/NMM_Cryptocurrencies.php? Like:

'NANO' => new NMM_Cryptocurrency('NANO', 'Nano', 6, 'nano_logo_small.png', 60, 'Ñ', false, false, true, ''),

And then for simple address checking:

    if ($cryptoId === 'NANO') {
        return preg_match('/^nano_[13][13456789abcdefghijkmnopqrstuwxyz]{59}/', $address);
    }

Thanks!

@pierstitus pierstitus linked a pull request Jun 3, 2021 that will close this issue
@pierstitus
Copy link

With the super fast confirmation times (less than a second) autopay would be valuable for Nano. It would be nice to have it real time with auto refresh, so no separate email is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants