Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDN string spacing #25

Open
brussee opened this issue Jan 10, 2023 · 1 comment
Open

RDN string spacing #25

brussee opened this issue Jan 10, 2023 · 1 comment

Comments

@brussee
Copy link

brussee commented Jan 10, 2023 •
edited
Loading

Is it correct to add extra whitespace here around the equals sign? (Probably, but...)
https://github.com/nonebot/nonecorn/blob/nonecorn_dev/src/hypercorn/utils.py#L277

Inserting whitespace is not advised because it may not be obvious to the user which whitespace is part of the DN string and which whitespace was added for readability.

From: https://www.rfc-editor.org/rfc/rfc4514

At least for consistency I'd argue to have a similar representation as the PEM format produced by OpenSSL, which does not have (extra) spaces around equals sign (checked on v1.1.1n).
@synodriver
Copy link
Member

Well, maybe we can add a config for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brussee @synodriver