Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VSCode Exploration Builds #50

Closed
zahidislm opened this issue Feb 5, 2019 · 3 comments
Closed

Add support for VSCode Exploration Builds #50

zahidislm opened this issue Feb 5, 2019 · 3 comments
Assignees

Comments

@zahidislm
Copy link

zahidislm commented Feb 5, 2019

Specifications

  • OS Version: Linux Ubuntu 18.10

  • VSCode Version: 1.32.0 Insiders [Electron 4 Exploration Builds]

Expected Behavior

Extension activates on startup and using any of the extension commands is expected work as usual.

Actual Behavior

Extension fails to activate on startup and commands are not found upon using them.
Probably from not being able to identify exploration builds as valid Insider builds after v2.1.0

Steps to Reproduce

  1. Install Insider exploration build from: Explore update to Electron 4 microsoft/vscode#61787
  2. Install vscode-syncing from Marketplace
  3. Attempt to use any command from extension (eg. syncing.uploadSettings)

Logs

[Extension Host] Activating extension 'nonoroazoro.syncing' failed: Cannot identify the VSCode version.. (at Object.showMessage (/usr/share/code-exploration/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:735:197))

[Extension Host] Here is the error stack: Error: Cannot identify the VSCode version.
at new a (/home/zahidislm/.vscode-exploration/extensions/nonoroazoro.syncing-2.1.0/dist/extension.js:1:12958)
at Function.create (/home/zahidislm/.vscode-exploration/extensions/nonoroazoro.syncing-2.1.0/dist/extension.js:1:13392)
at new l (/home/zahidislm/.vscode-exploration/extensions/nonoroazoro.syncing-2.1.0/dist/extension.js:1:86657)
at Function.create (/home/zahidislm/.vscode-exploration/extensions/nonoroazoro.syncing-2.1.0/dist/extension.js:1:86785)
at /home/zahidislm/.vscode-exploration/extensions/nonoroazoro.syncing-2.1.0/dist/extension.js:7:17800
at t.activate (/home/zahidislm/.vscode-exploration/extensions/nonoroazoro.syncing-2.1.0/dist/extension.js:7:17948)
at Function.t._callActivateOptional (/usr/share/code-exploration/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:740:963)
at Function.t._callActivate (/usr/share/code-exploration/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:740:634)
at /usr/share/code-exploration/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:739:810 (at /usr/share/code-exploration/resources/app/

Error: command 'syncing.uploadSettings' not found
at Proxy.t._tryExecuteCommand (commandService.ts:59)
at commandService.ts:52
at process._tickCallback (internal/process/next_tick.js:68)

@nonoroazoro
Copy link
Owner

@zahidislm Sorry for the late reply, I'll look into it.

@nonoroazoro nonoroazoro changed the title [BUG] Extension activation fails on exploration builds. [enhancement] Add support for electron 4 exploration builds Feb 12, 2019
@nonoroazoro nonoroazoro self-assigned this Feb 12, 2019
@nonoroazoro nonoroazoro changed the title [enhancement] Add support for electron 4 exploration builds Add support for VSCode Exploration Builds Feb 12, 2019
@nonoroazoro
Copy link
Owner

@zahidislm I've finished the patch and will release after testing.

@nonoroazoro
Copy link
Owner

nonoroazoro commented Feb 12, 2019

@zahidislm The new version is released which brings support for Exploration edition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants