Skip to content

Commit 2a39817

Browse files
nadavMiznadavMiz
committed
CI | seperate noobaa image build to different action
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
1 parent 7869340 commit 2a39817

File tree

8 files changed

+169
-39
lines changed

8 files changed

+169
-39
lines changed

‎.github/workflows/build-noobaa.yaml‎

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
name: Build Noobaa Image
2+
# This workflow builds the noobaa image and uploads it as an artifact.
3+
on: [push, pull_request, workflow_dispatch]
4+
5+
jobs:
6+
run-unit-tests-postgres:
7+
needs: build-noobaa-image
8+
uses: ./.github/workflows/postgres-unit-tests.yaml
9+
10+
run-sanity-ssl-tests:
11+
needs: build-noobaa-image
12+
uses: ./.github/workflows/sanity-ssl.yaml
13+
14+
run-nc-unit-tests:
15+
needs: build-noobaa-image
16+
uses: ./.github/workflows/nc_unit.yml
17+
18+
#nsfs-ceph-s3-tests:
19+
# needs: build-noobaa-image
20+
# uses: ./.github/workflows/ceph-s3-tests.yaml
21+
22+
run-unit-tests:
23+
needs: build-noobaa-image
24+
uses: ./.github/workflows/unit.yaml
25+
26+
build-noobaa-image:
27+
runs-on: ubuntu-latest
28+
timeout-minutes: 90
29+
concurrency:
30+
group: ${{ github.workflow }}-${{ github.ref }}
31+
cancel-in-progress: true
32+
steps:
33+
- name: Checkout
34+
uses: actions/checkout@v4
35+
36+
- name: make noobaa image
37+
run: make tester
38+
39+
- name: create docker artifact
40+
run: |
41+
docker save --output noobaa.tar noobaa
42+
docker save --output noobaa-tester.tar noobaa-tester
43+
44+
- name: upload noobaa docker image
45+
uses: actions/upload-artifact@v4
46+
with:
47+
name: noobaa-image
48+
path: noobaa.tar
49+
retention-days: "1"
50+
51+
- name: upload noobaa-tester docker image
52+
uses: actions/upload-artifact@v4
53+
with:
54+
name: noobaa-tester
55+
path: noobaa-tester.tar
56+
retention-days: "1"

‎.github/workflows/ceph-nsfs-s3-tests.yaml‎

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,32 @@
11
name: NSFS Ceph S3 Tests
2-
on: [push, pull_request, workflow_dispatch]
2+
on: [workflow_call]
33

44
jobs:
55
nsfs-ceph-s3-tests:
66
runs-on: ubuntu-latest
77
timeout-minutes: 90
8-
concurrency:
9-
group: ${{ github.workflow }}-${{ github.ref }}
10-
cancel-in-progress: true
118
steps:
12-
- name: Checkout noobaa-core
9+
- name: Checkout
1310
uses: actions/checkout@v4
1411
with:
15-
repository: 'noobaa/noobaa-core'
12+
repository: noobaa/noobaa-core
1613
path: 'noobaa-core'
1714

15+
- name: Download artifact
16+
uses: actions/download-artifact@v4
17+
with:
18+
name: noobaa-tester
19+
path: /tmp
20+
run-id: ${{ github.event.workflow_run.id }}
21+
github-token: ${{ github.token }}
22+
23+
- name: Load image
24+
run: docker load --input /tmp/noobaa-tester.tar
25+
1826
- name: Run NSFS Ceph s3-tests
1927
run: |
2028
set -x
2129
cd ./noobaa-core
2230
mkdir -p logs/ceph-nsfs-test-logs
2331
chmod 777 logs/ceph-nsfs-test-logs
24-
make test-nsfs-cephs3
32+
make test-nsfs-cephs3 -o tester

‎.github/workflows/ceph-s3-tests.yaml‎

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,31 @@
1-
name: Ceph S3 Tests
2-
on: [push, pull_request, workflow_dispatch]
1+
name: NSFS Ceph S3 Tests
2+
on: [workflow_call]
33

44
jobs:
5-
ceph-s3-tests:
5+
nsfs-ceph-s3-tests:
66
runs-on: ubuntu-latest
77
timeout-minutes: 90
8-
concurrency:
9-
group: ${{ github.workflow }}-${{ github.ref }}
10-
cancel-in-progress: true
8+
permissions: read-all
119
steps:
1210
- name: Checkout noobaa-core
1311
uses: actions/checkout@v4
1412
with:
1513
repository: 'noobaa/noobaa-core'
1614
path: 'noobaa-core'
1715

18-
- name: Run Ceph s3-tests
16+
- name: Download artifact
17+
uses: actions/download-artifact@v4
18+
with:
19+
name: noobaa-tester
20+
path: /tmp
21+
22+
- name: Load image
23+
run: docker load --input /tmp/noobaa-tester.tar
24+
25+
- name: Run NSFS Ceph s3-tests
1926
run: |
2027
set -x
2128
cd ./noobaa-core
22-
mkdir -p logs/ceph-test-logs
23-
chmod 777 logs/ceph-test-logs
24-
make test-cephs3
29+
mkdir -p logs/ceph-nsfs-test-logs
30+
chmod 777 logs/ceph-nsfs-test-logs
31+
make test-nsfs-cephs3 -o tester

‎.github/workflows/nc_unit.yml‎

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,29 @@
11
name: Non Containerized Unit Tests
2-
on: [push, pull_request]
2+
on: [workflow_call]
33

44
jobs:
55
run-nc-unit-tests:
66
runs-on: ubuntu-latest
77
timeout-minutes: 90
8-
concurrency:
9-
group: ${{ github.workflow }}-${{ github.ref }}
10-
cancel-in-progress: true
8+
permissions: read-all
119
steps:
12-
- name: checkout
10+
- name: Checkout noobaa-core
1311
uses: actions/checkout@v4
12+
with:
13+
repository: 'noobaa/noobaa-core'
14+
path: 'noobaa-core'
15+
16+
- name: Download artifact
17+
uses: actions/download-artifact@v4
18+
with:
19+
name: noobaa-tester
20+
path: /tmp
21+
run-id: ${{ github.event.workflow_run.id }}
22+
github-token: ${{ github.token }}
23+
24+
- name: Load image
25+
run: docker load --input /tmp/noobaa-tester.tar
1426

1527
- name: Run Non Containerized Test
1628
run: |
17-
make run-nc-tests
29+
make run-nc-tests -o tester

‎.github/workflows/postgres-unit-tests.yaml‎

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,25 @@
11
name: Unit Tests with Postgres
2-
on: [push, pull_request]
2+
on: [workflow_call]
33

44
jobs:
55
run-unit-tests-postgres:
66
runs-on: ubuntu-latest
77
timeout-minutes: 90
8-
concurrency:
9-
group: ${{ github.workflow }}-${{ github.ref }}
10-
cancel-in-progress: true
8+
permissions: read-all
119
steps:
1210
- name: Checkout
1311
uses: actions/checkout@v4
1412

13+
- name: Download artifact
14+
uses: actions/download-artifact@v4
15+
with:
16+
name: noobaa-tester
17+
path: /tmp
18+
run-id: ${{ github.event.workflow_call.id }}
19+
github-token: ${{ github.token }}
20+
21+
- name: Load image
22+
run: docker load --input /tmp/noobaa-tester.tar
23+
1524
- name: Run Unit Tests with Postgres
16-
run: make test-postgres
25+
run: make test-postgres -o tester

‎.github/workflows/sanity-ssl.yaml‎

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,29 @@
11
name: Build & Sanity SSL
2-
on: [push, pull_request]
2+
on: [workflow_call]
33

44
jobs:
55
run-sanity-ssl-tests:
66
runs-on: ubuntu-latest
77
timeout-minutes: 90
8-
concurrency:
9-
group: ${{ github.workflow }}-${{ github.ref }}
10-
cancel-in-progress: true
8+
permissions: read-all
119
steps:
1210
- name: Checkout
1311
uses: actions/checkout@v4
1412

13+
- name: Download artifact
14+
uses: actions/download-artifact@v4
15+
with:
16+
name: noobaa-tester
17+
path: /tmp
18+
run-id: ${{ github.workflow.id }}
19+
github-token: ${{ github.token }}
20+
21+
- name: Load image
22+
run: docker load --input /tmp/noobaa-tester.tar
23+
1524
- name: Run Build & SSL Sanity Tests
1625
run: |
1726
set -x
1827
mkdir -p logs/sanity-test-logs
1928
chmod 777 logs/sanity-test-logs
20-
make test-external-pg-sanity
29+
make test-external-pg-sanity -o tester

‎.github/workflows/sanity.yaml‎

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
name: Build & Sanity
2-
on: [push, pull_request]
2+
on:
3+
workflow_run:
4+
workflows: ["Build Noobaa Image"]
5+
types:
6+
- completed
37

48
jobs:
59
run-sanity-tests:
@@ -12,9 +16,20 @@ jobs:
1216
- name: Checkout
1317
uses: actions/checkout@v4
1418

19+
- name: Download artifact
20+
uses: actions/download-artifact@v4
21+
with:
22+
name: noobaa-tester
23+
path: /tmp
24+
run-id: ${{ github.event.workflow_run.id }}
25+
github-token: ${{ github.token }}
26+
27+
- name: Load image
28+
run: docker load --input /tmp/noobaa-tester.tar
29+
1530
- name: Run Build & Sanity Tests
1631
run: |
1732
set -x
1833
mkdir -p logs/sanity-test-logs
1934
chmod 777 logs/sanity-test-logs
20-
make test-sanity
35+
make test-sanity -o tester

‎.github/workflows/unit.yaml‎

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: Unit Tests
2-
on: [push, pull_request]
2+
on: [workflow_call]
33

44
jobs:
55
run-unit-tests:
@@ -9,10 +9,24 @@ jobs:
99
group: ${{ github.workflow }}-${{ github.ref }}
1010
cancel-in-progress: true
1111
steps:
12-
- name: checkout
12+
- name: Checkout
1313
uses: actions/checkout@v4
14+
with:
15+
repository: noobaa/noobaa-core
16+
path: 'noobaa-core'
17+
18+
- name: Download artifact
19+
uses: actions/download-artifact@v4
20+
with:
21+
name: noobaa-tester
22+
path: /tmp
23+
run-id: ${{ github.event.workflow_run.id }}
24+
github-token: ${{ github.token }}
25+
26+
- name: Load image
27+
run: docker load --input /tmp/noobaa-tester.tar
1428

1529
- name: Run Test
1630
run: |
17-
make test
18-
make root-perm-test
31+
make test -o tester
32+
make root-perm-test -o tester

0 commit comments

Comments
 (0)