Each minute: "node service is not as expected. setting node service to enabled"

[vinzent]

We have 3 OpenShift 4.13 clusters with NooBaa (as part of ODF).

Each instance logs every minute:

node service is not as expected. setting node service to enabled

The log message originates from here:

noobaa-core/src/server/node_services/nodes_monitor.js

Lines 1253 to 1256 in 2edff0b

	if (service_enabled_not_changed && location_info_not_changed) {
	return;
	}
	dbg.log0(`node service is not as expected. setting node service to ${should_enable ? 'enabled' : 'disabled'}`);

As nothing has changed, I would expect that the flow would end in return on line 1254 instead.

Why does NooBaa think something has changed each minute?

[liranmauda]

Hi @vinzent
This seems to be a bug.
we are populating location_info.region if the item_pool exists, regardless if it is undefined

Then when we do _.isEqual it will fail.

Great catch,
Can you create an issue from this discussion, so we can handle it?

Best Regards,
Liran.

[liranmauda]

In any case, #7831

[vinzent]

Thanks a lot for the quick-fix! Should I still open an issue?

[liranmauda]

yes, Please open an Issue
I will close this discussion.