Fix parse error for query_events (fix for PR#360) #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongwook-chan
referenced
this pull request
in the4thdoctor/pg_chameleon
Feb 25, 2023
with encoding utf8mb4. TODO - file a bug report
…#38c7a90 Analysis - Could not parse status variables in query events for MariaDB - Because the library was not aware of MariaDB-exclusive status variables Implementation - Added MariaDB-only status variables - Added Exception to raise when status variable parse failed - Added tests for parsing query events for MariaDB
dongwook-chan
force-pushed
the
fix-mariadb-only-status-vars
branch
from
f20649f
to
ef7fc4b
Compare
|
Any chance to get this PR merged and a new release out? |
|
@julien-duponchelle |
|
Thanks I'm trying to get it merge and release during the week end |
|
Released! |
|
ta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: python-mysql-replication issue#380, pg_cameleon commit#38c7a90
Analysis
Implementation