Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

fix(Alert): Avoid conflict with other header classnames #245

Closed
wants to merge 1 commit into from
Closed

fix(Alert): Avoid conflict with other header classnames #245

wants to merge 1 commit into from

Conversation

codler
Copy link

@codler codler commented Jun 16, 2017

No description provided.

@codler codler requested review from willeeklund and bstream June 16, 2017 06:57
@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.031% when pulling 37cb998 on fix/alert-classname into 3140735 on master.

@bstream
Copy link
Contributor

bstream commented Jun 16, 2017

First: Thanks for the PR! ✨
Second: I would like to get away from using bare classnames so I will try to fix that and make a separate PR for that. If I cannot get it to work soon™ I will merge this :)

bstream pushed a commit that referenced this pull request Jun 16, 2017
fix(Alert): Convert bare classes to jss (header, vertical). Closes #245
24d70a5
@bstream
Copy link
Contributor

bstream commented Jun 16, 2017

I now have a suggestion for this in #247. Check it out and see if it fits your needs :) @codler

@bstream bstream closed this in 1315a74 Jun 16, 2017
@iamstarkov iamstarkov deleted the fix/alert-classname branch June 19, 2017 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willeeklund willeeklund Awaiting requested review from willeeklund

@bstream bstream Awaiting requested review from bstream

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codler @coveralls @bstream